Bug 244972 – Integrate ARIA element reflection in the Accessibility Tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Manuel Rego Casasnovas]

IDREF element reflection hasn't been hooked up with AccessibilityObject.

Right now if you do something like the following example, the a11y tree doesn't know anything about the label you're assigning to the custom input:
        <label id="anotherLabel">Another label</label>
        <x-input-idref id="myxinput"></x-input-idref>

        <script>
          class XInputIDREF extends HTMLElement {
            constructor() {
              super();
              this.attachShadow({ mode: "open" });
              let input = document.createElement("input");
              input.id = "innerbutton";
              this.shadowRoot.appendChild(input);
              input.ariaLabelledByElements = [anotherLabel];
            }
          }
          customElements.define("x-input-idref", XInputIDREF);

If you use the accessibility info in the inspector, you'll see the inner <input> doesn't have the label associated to it.
This is because as the attribute is not reflected, as the label is not in the shadow tree, and we need to update AccessibilityObject::elementsFromAttribute() to return the explicitly set elements in that scenario.

[Radar WebKit Bug Importer]

<rdar://problem/99742765>

[Ryosuke Niwa]

I think this is also broken when the referenced element doesn't have an ID

[Manuel Rego Casasnovas]

Pull request: https://github.com/WebKit/WebKit/pull/4299

[Manuel Rego Casasnovas]

Created attachment 462484 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 462484 [details]
Patch

Sorry wrong command to upload patch.

[EWS]

Committed 254905@main (5a61ea9a8257): <https://commits.webkit.org/254905@main>

Reviewed commits have been landed. Closing PR #4299 and removing active labels.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 245762

[Manuel Rego Casasnovas]

*** Bug 245761 has been marked as a duplicate of this bug. ***

[Manuel Rego Casasnovas]

New pull request: https://github.com/WebKit/WebKit/pull/4784

[EWS]

Committed 254985@main (fa51d4c1048c): <https://commits.webkit.org/254985@main>

Reviewed commits have been landed. Closing PR #4784 and removing active labels.