Bug 244960 - Revision field in the json data generated by run-webkit-tests is empty since migration to git
Summary: Revision field in the json data generated by run-webkit-tests is empty since ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-08 20:53 PDT by Carlos Alberto Lopez Perez
Modified: 2022-09-12 04:32 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2022-09-08 20:53:35 PDT 
run-webkit-tests generates a json file with the information of the run (usually named full_results.json)

This json included a "revision" field with the SVN revision of the checkout where the run was executed. But since the migration to git this "revision" field is null.

See example: https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/254161%40main%20%2825393%29/full_results.json (See the "revision" key at the end of the json)

This issue broke the webkit-testhunter tool that relied on this field to index and sort the runs. See: https://github.com/clopez/webkit-testhunter/issues/11
Comment 1 Carlos Alberto Lopez Perez 2022-09-08 21:09:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4152
Comment 2 EWS 2022-09-12 04:32:00 PDT 
Committed 254376@main (ee1be476e83b): <https://commits.webkit.org/254376@main>

Reviewed commits have been landed. Closing PR #4152 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-12 04:32:18 PDT 
<rdar://problem/99817002>