RESOLVED FIXED 24491
Rename posOffset to m_offset, get rid of accessor 
https://bugs.webkit.org/show_bug.cgi?id=24491
Summary Rename posOffset to m_offset, get rid of accessor
Xan Lopez
Reported 2009-03-10 08:31:54 PDT
As suggested in dom/Position.h, this patch gets rid of the 'offset()' accessor and renames posOffset to m_offset. I've used m_offset instead of offset to follow the style guide lines, since Position is still a class and not a structure. If the long term plan is still to make it a structure it would be pretty easy to just s/m_offset/offset/ globally when that is achieved.
Attachments
posoffset.patch (84.87 KB, patch)
2009-03-10 08:34 PDT, Xan Lopez 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2009-03-10 08:34:37 PDT
Created attachment 28437 [details] posoffset.patch
Darin Adler
Comment 2 2009-03-10 09:05:57 PDT
Comment on attachment 28437 [details] posoffset.patch Seems fine, r=me
Xan Lopez
Comment 3 2009-03-10 09:12:00 PDT
Thanks, landed in r41553.
Note You need to log in before you can comment on or make changes to this bug.