Bug 24491 - Rename posOffset to m_offset, get rid of accessor
Summary: Rename posOffset to m_offset, get rid of accessor
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-03-10 08:31 PDT by Xan Lopez
Modified: 2009-03-10 09:12 PDT (History)
0 users

See Also:

posoffset.patch (84.87 KB, patch)
2009-03-10 08:34 PDT, Xan Lopez
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-03-10 08:31:54 PDT
As suggested in dom/Position.h, this patch gets rid of the 'offset()' accessor and renames posOffset to m_offset. I've used m_offset instead of offset to follow the style guide lines, since Position is still a class and not a structure. If the long term plan is still to make it a structure it would be pretty easy to just s/m_offset/offset/ globally when that is achieved.
Comment 1 Xan Lopez 2009-03-10 08:34:37 PDT
Created attachment 28437 [details]
Comment 2 Darin Adler 2009-03-10 09:05:57 PDT
Comment on attachment 28437 [details]

Seems fine, r=me
Comment 3 Xan Lopez 2009-03-10 09:12:00 PDT
Thanks, landed in r41553.