Bug 24484 - Amalgamate separate overflowHeight etc. methods to avoid lots of hash lookups in RenderReplaced
Summary: Amalgamate separate overflowHeight etc. methods to avoid lots of hash lookups...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-09 22:52 PDT by Simon Fraser (smfr)
Modified: 2012-02-27 18:57 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-03-09 22:52:00 PDT
If a RenderReplaced has overflow, it has to do a hash lookup for each call to overflowHeight(), overflowWidth(), overflowLeft(), overflowTop() and overflowRect().

We should use fewer methods that return IntSizes etc. to avoid all these hash lookups.
Comment 1 Julien Chaffraix 2012-02-27 18:56:39 PST
It looks like the overflow logic has been refactored since this bug was opened and we don't have a hash lookup for any RenderReplaced overflow functions anymore.

Simon, is there something to be saved of it or should we just close it?
Comment 2 Julien Chaffraix 2012-02-27 18:57:56 PST
Oops, I did not mean to close it. Feel free to reopen if there is something to be saved.