RESOLVED DUPLICATE of bug 255258 244822
merge Element::attributeChanged and Element::parseAttribute and avoid base class calls when an attribute is handled 
https://bugs.webkit.org/show_bug.cgi?id=244822
Summary merge Element::attributeChanged and Element::parseAttribute and avoid base cl...
Cameron McCormack (:heycam)
Reported 2022-09-05 19:34:41 PDT
I can't see a good reason to have separate Element::attributeChanged and Element::parseAttribute member functions. The patch in this bug will do two things: 1. Merge parseAttribute into attributeChanged, to avoid one virtual function call. 2. Tweak the contents of attributeChanged functions to consistently avoid calling the base class attributeChanged if an attribute is handled in the derived class. As well as reducing the amount of work done when an attribute is changed, very slightly, this sets the stage for a subsequent patch to use an enum value to represent known attribute names instead of checking for QualifiedName equality.
Attachments
Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2022-09-05 19:40:15 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4040
Radar WebKit Bug Importer
Comment 2 2022-09-12 19:35:17 PDT
<rdar://problem/99850653>
Anne van Kesteren
Comment 3 2023-07-25 06:50:29 PDT
*** This bug has been marked as a duplicate of bug 255258 ***
Note You need to log in before you can comment on or make changes to this bug.