Bug 24482 - REGRESSION (r38635): JavaScript error using Oneida wedding registry page
Summary: REGRESSION (r38635): JavaScript error using Oneida wedding registry page
Status: RESOLVED DUPLICATE of bug 24291
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL: https://www.oneida.com/index.cfm/fuse...
Keywords: InRadar, NeedsReduction, Regression
Depends on:
Reported: 2009-03-09 21:11 PDT by David Kilzer (:ddkilzer)
Modified: 2009-03-10 06:25 PDT (History)
3 users (show)

See Also:

Offline test case (21.25 KB, application/zip)
2009-03-09 22:40 PDT, David Kilzer (:ddkilzer)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-03-09 21:11:23 PDT
The Oneida registry page has a ship-to address form that contains JavaScript to ensure that the address lines are not more than 26 characters long.  This works in Safari 3.2.x, but fails in Safari 4 Public Beta and in the latest WebKit nightly build (r41521).

1. Register for an account on <http://www.oneida.com/>.
2. On the register page, hit Cmd-Opt-C to open the Web Inspector.  The following error is printed in the console:  "TypeError: Result of expression 'wishListCreateFormFormObj.address1.validateLengthLT' [undefined] is not a function."
3. Fill out Ship-To address, using an address line longer than 26 characters.
4. Hit "Save" button.

The page is submitting (instead of displaying an alert message), and an error page is printed instead.

This is a regression from Safari 3.2.x.

The bisect-builds script reports:

Works: r38592  Fails: r38645
Comment 1 David Kilzer (:ddkilzer) 2009-03-09 21:43:18 PDT
Looks like the validateLengthLT() function is part of the qForms library:

Comment 2 David Kilzer (:ddkilzer) 2009-03-09 21:44:03 PDT
Comment 3 David Kilzer (:ddkilzer) 2009-03-09 21:56:10 PDT
An internal bisect reveals:

Works: r38632  Fails: r38635
Comment 4 David Kilzer (:ddkilzer) 2009-03-09 21:58:48 PDT
Looks like more fall-out from r38635:


I will create a reduced (offline) test case.
Comment 5 David Kilzer (:ddkilzer) 2009-03-09 22:40:48 PDT
Created attachment 28426 [details]
Offline test case

This is an offline test case that reproduces the issue.  It could be reduced (much) further.
Comment 6 Cameron Zwarich (cpst) 2009-03-10 03:57:21 PDT
I'll take this bug.
Comment 7 Cameron Zwarich (cpst) 2009-03-10 04:09:24 PDT
As I sort of expected, this is a dupe of bug 24291 and is fixed by my patch there. I'll make some tests and put it up for review.

*** This bug has been marked as a duplicate of 24291 ***