Bug 244799 - [css-contain] Fix contain-inline-size-replaced.html
Summary: [css-contain] Fix contain-inline-size-replaced.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-05 03:23 PDT by Rob Buis
Modified: 2022-09-07 06:14 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.03 KB, patch)
2022-09-05 03:25 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (10.42 KB, patch)
2022-09-05 12:21 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (30.12 KB, patch)
2022-09-06 01:54 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (30.30 KB, patch)
2022-09-06 06:27 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (30.80 KB, patch)
2022-09-06 13:47 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (30.93 KB, patch)
2022-09-07 01:04 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.08 KB, patch)
2022-09-07 04:46 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-09-05 03:23:12 PDT 
Fix contain-inline-size-replaced.html.
Comment 1 Rob Buis 2022-09-05 03:25:24 PDT 
Created attachment 462140 [details]
Patch
Comment 2 Rob Buis 2022-09-05 12:21:21 PDT 
Created attachment 462147 [details]
Patch
Comment 3 Rob Buis 2022-09-06 01:54:58 PDT 
Created attachment 462160 [details]
Patch
Comment 4 EWS Watchlist 2022-09-06 01:56:34 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Rob Buis 2022-09-06 06:27:01 PDT 
Created attachment 462164 [details]
Patch
Comment 6 Rob Buis 2022-09-06 13:47:24 PDT 
Created attachment 462168 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2022-09-06 23:26:39 PDT 
Comment on attachment 462168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462168&action=review

r=me

> Source/WebCore/rendering/RenderReplaced.cpp:572
> +    if (shouldApplyInlineSizeContainment())
> +        return { };

You're using `{ }` here and `LayoutUnit()` above, can you be consistent if they're equivalent?
Comment 8 Rob Buis 2022-09-07 01:04:19 PDT 
Created attachment 462176 [details]
Patch
Comment 9 Rob Buis 2022-09-07 04:46:15 PDT 
Created attachment 462178 [details]
Patch
Comment 10 EWS 2022-09-07 06:13:01 PDT 
Committed 254226@main (113089411a3a): <https://commits.webkit.org/254226@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462178 [details].
Comment 11 Radar WebKit Bug Importer 2022-09-07 06:14:21 PDT 
<rdar://problem/99646848>