Bug 244799 – [css-contain] Fix contain-inline-size-replaced.html

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

Fix contain-inline-size-replaced.html.

[Rob Buis]

Created attachment 462140 [details]
Patch

[Rob Buis]

Created attachment 462147 [details]
Patch

[Rob Buis]

Created attachment 462160 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Rob Buis]

Created attachment 462164 [details]
Patch

[Rob Buis]

Created attachment 462168 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 462168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462168&action=review

r=me

> Source/WebCore/rendering/RenderReplaced.cpp:572
> +    if (shouldApplyInlineSizeContainment())
> +        return { };

You're using `{ }` here and `LayoutUnit()` above, can you be consistent if they're equivalent?

[Rob Buis]

Created attachment 462176 [details]
Patch

[Rob Buis]

Created attachment 462178 [details]
Patch

[EWS]

Committed 254226@main (113089411a3a): <https://commits.webkit.org/254226@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462178 [details].

[Radar WebKit Bug Importer]

<rdar://problem/99646848>