ssia
Created attachment 462131 [details] Patch
Created attachment 462132 [details] Patch
Created attachment 462134 [details] Patch
Comment on attachment 462134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462134&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:937 > + // we can still continue placing inline content on the line, but we have to save all the upcoming floats for subsequent lines. > + auto lineHasSkippedFloats = !m_overflowingFloats.isEmpty(); > + if (lineHasSkippedFloats) > + return false; > + if (lineBoxConstraintApplies == LineBoxConstraintApplies::No) { > + // This is an overflowing float from previous line. Now we need to find a place for it. > + return true; > + } maybe we can assert these conditions are mutually exclusive
(In reply to Antti Koivisto from comment #4) > Comment on attachment 462134 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=462134&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:937 > > + // we can still continue placing inline content on the line, but we have to save all the upcoming floats for subsequent lines. > > + auto lineHasSkippedFloats = !m_overflowingFloats.isEmpty(); > > + if (lineHasSkippedFloats) > > + return false; > > + if (lineBoxConstraintApplies == LineBoxConstraintApplies::No) { > > + // This is an overflowing float from previous line. Now we need to find a place for it. > > + return true; > > + } > > maybe we can assert these conditions are mutually exclusive good idea!
Created attachment 462145 [details] Patch
Committed 254170@main (9f5be0d75394): <https://commits.webkit.org/254170@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462145 [details].
<rdar://problem/99578693>