Bug 244766 - AX ITM: Stop unnecessarily caching 35 live-tree-only properties
Summary: AX ITM: Stop unnecessarily caching 35 live-tree-only properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-03 14:03 PDT by Tyler Wilcock
Modified: 2022-09-04 10:11 PDT (History)
10 users (show)

See Also:


Attachments
Patch (45.84 KB, patch)
2022-09-03 14:10 PDT, Tyler Wilcock
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (44.17 KB, patch)
2022-09-03 14:40 PDT, Tyler Wilcock
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (42.81 KB, patch)
2022-09-03 15:36 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (50.53 KB, patch)
2022-09-03 16:14 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-09-03 14:03:47 PDT
We are currently caching a lot of properties for functions that are useful only in the context of the live tree. This is wasteful in terms of CPU and memory.
Comment 1 Radar WebKit Bug Importer 2022-09-03 14:03:58 PDT
<rdar://problem/99531165>
Comment 2 Tyler Wilcock 2022-09-03 14:10:40 PDT
Created attachment 462113 [details]
Patch
Comment 3 Tyler Wilcock 2022-09-03 14:40:43 PDT
Created attachment 462114 [details]
Patch
Comment 4 Tyler Wilcock 2022-09-03 15:36:43 PDT
Created attachment 462115 [details]
Patch
Comment 5 Tyler Wilcock 2022-09-03 16:14:22 PDT
Created attachment 462116 [details]
Patch
Comment 6 EWS 2022-09-04 10:11:14 PDT
Committed 254144@main (14ffd241d584): <https://commits.webkit.org/254144@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462116 [details].