Bug 244734 - Add Flexbox last baseline alignment for block flow items
Summary: Add Flexbox last baseline alignment for block flow items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
: 243523 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-02 15:25 PDT by Sammy Gill
Modified: 2022-10-11 09:20 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2022-09-02 15:25:04 PDT
From CSS Box Alignment Module Level 3:

The first/last baseline set of a block container is generated from the dominant first/last baseline of the first/last in-flow line box in the block container, or is taken from the first/last in-flow block-level child in the block container that contributes a set of first/last baselines, whichever comes first/last. If there is no such line box or child, then the block container has no baseline set.

However, for legacy reasons a block-level or inline-level scroll container always has a last baseline set, whose baselines all correspond to its block-end margin edge.

Need to implement the ability to get the last line's baseline value for block flow elements so that they may participate in last baseline alignment.
Comment 1 Radar WebKit Bug Importer 2022-09-02 15:26:49 PDT
<rdar://problem/99506835>
Comment 2 Sammy Gill 2022-09-06 13:13:40 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4067
Comment 3 EWS 2022-10-11 08:35:17 PDT
Committed 255383@main (a7e014a01430): <https://commits.webkit.org/255383@main>

Reviewed commits have been landed. Closing PR #4067 and removing active labels.
Comment 4 Tim Nguyen (:ntim) 2022-10-11 09:15:16 PDT
*** Bug 243523 has been marked as a duplicate of this bug. ***