Bug 244706 – CSS - overflow: clip is not working on SVG elements

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Karl Dubost]

https://wpt.fyi/results/svg/render/reftests/overflow-clip.html?label=experimental&label=master&aligned

This test fails
http://wpt.live/svg/render/reftests/overflow-clip.html

data:text/html,<svg%20style="overflow:%20clip;%20width:%20100px;%20height:%20100px">%20%20%20<rect%20width="200"%20height="200"%20fill="green">%20</svg>



while it is working for simple divs.
data:text/html,<div%20style="overflow:clip;width:100px;height:100px"><div%20style="width:200px;height:200px;background-color:gold"></div></div>

Work in Firefox and Chrome.

[Radar WebKit Bug Importer]

<rdar://problem/99479553>

[Rob Buis]

Created attachment 462177 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 462177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462177&action=review

> Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:216
> +    return effectiveOverflowX() == Overflow::Hidden || style().overflowX() == Overflow::Auto

Would be nice to have a isNonVisibleOverflow(Overflow) helper we can use everywhere.

[Rob Buis]

Created attachment 462199 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 462199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462199&action=review

> Source/WebCore/rendering/style/RenderStyle.h:2553
> +inline bool isNonVisibleOverflow(const Overflow& overflow)

Overflow is a uint8_t enum, so it's more efficient to pass by value.

[Rob Buis]

Created attachment 462221 [details]
Patch

[EWS]

Committed 254295@main (88bf94fa06f3): <https://commits.webkit.org/254295@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462221 [details].