RESOLVED CONFIGURATION CHANGED 244696
REGRESSION (253726@main): [ macOS wk1 Debug ] ASSERTION FAILED: !needsLayout() ERROR: Unknown key, 'modernMediaControls' 
https://bugs.webkit.org/show_bug.cgi?id=244696
Summary REGRESSION (253726@main): [ macOS wk1 Debug ] ASSERTION FAILED: !needsLayout...
Karl Rackler
Reported 2022-09-01 17:58:40 PDT
Description: media/modern-media-controls/media-documents/insert-style-should-not-crash.html is a flaky crash This test was passing consistently until at 253726@main, where it began to flaky crash. REPRODUCTION STEPS I can reproduce this on 253726@main but cannot reproduce it on 253725@main or earlier. Command: run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry media/modern-media-controls/media-documents/insert-style-should-not-crash.html Result: documents/insert-style-should-not-crash.html Unexpected flakiness: crashes (1) media/modern-media-controls/media-documents/insert-style-should-not-crash.html [ Pass Crash ] History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-documents%2Finsert-style-should-not-crash.html&platform=mac&style=debug&flavor=wk1 Crash Log: No crash log found for DumpRenderTree:54036. stdout: stderr: ERROR: Unknown key, 'modernMediaControls', in test header in /Volumes/Data/worker/Apple-Monterey-Debug-WK1-Tests/build/LayoutTests/media/modern-media-controls/media-documents/insert-style-should-not-crash.html /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Tools/TestRunnerShared/TestFeatures.cpp(271) : WTR::TestFeatures WTR::parseTestHeaderString(const std::string &, std::filesystem::path, const std::unordered_map<std::string, TestHeaderKeyType> &) 2022-09-01 11:18:51.435 DumpRenderTree[54036:19559529] nil host used in call to allowsSpecificHTTPSCertificateForHost 2022-09-01 11:18:51.435 DumpRenderTree[54036:19559529] nil host used in call to allowsAnyHTTPSCertificateForHost: 2022-09-01 11:18:51.514 DumpRenderTree[54036:19559529] nil host used in call to allowsSpecificHTTPSCertificateForHost 2022-09-01 11:18:51.514 DumpRenderTree[54036:19559529] nil host used in call to allowsAnyHTTPSCertificateForHost: ASSERTION FAILED: !needsLayout() page/FrameView.cpp(4560) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext *) 1 0x10f8e8069 WTFCrash 2 0x19fdb6efb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1a45e74ef WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 4 0x10c925a1c -[WebFrame(WebInternal) _drawRect:contentsOnly:] 5 0x10c9499d3 -[WebHTMLView drawSingleRect:] 6 0x10c94a035 -[WebHTMLView drawRect:] 7 0x7ff80bec3280 _NSViewDrawRect 8 0x7ff80c5de3bd -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 9 0x10c93d7c6 -[WebHTMLView(WebPrivate) _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 10 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 11 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 12 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 13 0x7ff80c033195 -[NSView displayRectIgnoringOpacity:inContext:] 14 0x1a24afd2c WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 15 0x1a48a3023 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 16 0x1a53d0b99 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 17 0x1a53d1453 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 18 0x1a5261246 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 19 0x1a525efbd WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 20 0x1a525b278 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 21 0x1a52a54e2 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_11::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const 22 0x1a52a4e06 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) 23 0x1a52a6241 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 24 0x1a4ace4f0 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 25 0x1a4bb4a7f WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 26 0x1a20d0700 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int) 27 0x1a21db696 -[WebLayer drawInContext:] 28 0x7ff8103f199d CABackingStoreUpdate_ 29 0x7ff8104559fd invocation function for block in CA::Layer::display_() 30 0x7ff8103f09d1 -[CALayer _display] 31 0x1a21dbfad -[WebSimpleLayer display]
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-09-01 17:58:58 PDT
<rdar://problem/99466640>
Karl Rackler
Comment 2 2022-09-01 18:03:21 PDT
I have marked this test as a flaky crash while this issue is investigated.
EWS
Comment 3 2022-09-01 18:10:30 PDT
Test gardening commit 254082@main (a5d7c6e85a19): <https://commits.webkit.org/254082@main> Reviewed commits have been landed. Closing PR #3942 and removing active labels.
Karl Rackler
Comment 4 2022-09-07 05:57:10 PDT
Skipping test affected by wk1 debug only assertion caused by an underlying issue. https://github.com/WebKit/WebKit/pull/4093
Note You need to log in before you can comment on or make changes to this bug.