Bug 244687 – AX ITM: pass Ref<AXCoreObject> to live objects by reference.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Follow up to patch in https://bugs.webkit.org/show_bug.cgi?id=241810.

[Radar WebKit Bug Importer]

<rdar://problem/99457705>

[Andres Gonzalez]

Created attachment 462080 [details]
Patch

[Andres Gonzalez]

Created attachment 462082 [details]
Patch

[Tyler Wilcock]

Comment on attachment 462082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462082&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:273
> +        AXLOG(axObject.ptr());

I think (but am not 100% sure) this will only log the memory address of the object. Does axObject.get() (which returns a reference) compile?

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #4)
> Comment on attachment 462082 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462082&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:273
> > +        AXLOG(axObject.ptr());
> 
> I think (but am not 100% sure) this will only log the memory address of the
> object. Does axObject.get() (which returns a reference) compile?

No, AXLogger::log takes a pointer not a reference, so you need ptr().

[EWS]

Committed 254107@main (276e9d6f7b36): <https://commits.webkit.org/254107@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462082 [details].