Bug 244680 - REGRESSION(253383@main): Build broken with ENABLE(VIDEO) disabled
Summary: REGRESSION(253383@main): Build broken with ENABLE(VIDEO) disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-01 11:27 PDT by Adrian Perez
Modified: 2022-09-02 02:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-09-01 11:27:04 PDT 
In file included from /home/aperez/buildroot/output-rpi4test/build/wpewebkit-custom/WebCore/DerivedSources/unified-sources/UnifiedSource-be65d27a-10.cpp:4:
/home/aperez/buildroot/output-rpi4test/build/wpewebkit-custom/Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp: In function ‘bool WebCore::FragmentDirectiveRangeFinder::isSearchInvisible(const WebCore::Node&)’:
/home/aperez/buildroot/output-rpi4test/build/wpewebkit-custom/Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp:70:15: error: ‘HTMLAudioElement’ was not declared in this scope; did you mean ‘HTMLVideoElement’?
   70 |         || is<HTMLAudioElement>(node))
      |               ^~~~~~~~~~~~~~~~
      |               HTMLVideoElement
/home/aperez/buildroot/output-rpi4test/build/wpewebkit-custom/Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp:70:37: error: no matching function for call to ‘is<<expression error
> >(const WebCore::Node&)’
   70 |         || is<HTMLAudioElement>(node))
      |                                     ^
Comment 1 Adrian Perez 2022-09-01 12:32:39 PDT 
Also:

/home/aperez/buildroot/output-rpi4test/build/wpewebkit-custom/Source/WebCore/page/ContextMenuController.cpp:1291:95: error: ‘contextMenuItemTagShowMediaStats’ was not declared in this scope; did you mean ‘ContextMenuItemTagShowMediaStats’?
 1291 |         ContextMenuItem ShowMediaStats(CheckableActionType, ContextMenuItemTagShowMediaStats, contextMenuItemTagShowMediaStats());
      |                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                               ContextMenuItemTagShowMediaStats
Comment 2 Adrian Perez 2022-09-01 12:54:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3925
Comment 3 EWS 2022-09-02 02:23:56 PDT 
Committed 254094@main (6989aa1a1476): <https://commits.webkit.org/254094@main>

Reviewed commits have been landed. Closing PR #3925 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-09-02 02:24:16 PDT 
<rdar://problem/99480443>