NEW 244652
Test addition (252960@main): [ macOS wk1 Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/bfcache/embedded-mp4.html is a flaky crash 
https://bugs.webkit.org/show_bug.cgi?id=244652
Summary Test addition (252960@main): [ macOS wk1 Debug ] imported/w3c/web-platform-te...
Karl Rackler
Reported 2022-08-31 18:35:07 PDT
Description: imported/w3c/web-platform-tests/html/semantics/embedded-content/bfcache/embedded-mp4.html This test has been a flaky crash since being added at 252960@main. REPRODUCTION STEPS I can reproduce this on 254018@main ToT. Command: run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry imported/w3c/web-platform-tests/html/semantics/embedded-content/bfcache/embedded-mp4.html Result: Unexpected flakiness: crashes (1) imported/w3c/web-platform-tests/html/semantics/embedded-content/bfcache/embedded-mp4.html [ Crash Pass ] History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fembedded-content%2Fbfcache%2Fembedded-mp4.html&platform=mac&style=debug&flavor=wk1&limit=50000 Crash Log: No crash log found for DumpRenderTree:88816. stdout: stderr: ASSERTION FAILED: !needsLayout() page/FrameView.cpp(4560) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext *) 1 0x11df30da9 WTFCrash 2 0x12701f0fb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12b8352af WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 4 0x1083bda1c -[WebFrame(WebInternal) _drawRect:contentsOnly:] 5 0x1083e19d3 -[WebHTMLView drawSingleRect:] 6 0x1083e2035 -[WebHTMLView drawRect:] 7 0x7ff80bec3280 _NSViewDrawRect 8 0x7ff80c5de3bd -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 9 0x1083d57c6 -[WebHTMLView(WebPrivate) _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 10 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 11 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 12 0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] 13 0x7ff80c033195 -[NSView displayRectIgnoringOpacity:inContext:] 14 0x1296fce9c WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 15 0x12baf0cc3 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 16 0x12c61c849 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 17 0x12c61d103 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 18 0x12c42e7fc WebCore::RenderEmbeddedObject::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 19 0x12c4acef6 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 20 0x12c4aac6d WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 21 0x12c4a6f28 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 22 0x12c4f1192 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_11::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const 23 0x12c4f0ab6 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) 24 0x12c4f1ef1 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 25 0x12bd1c120 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 26 0x12be0272f WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 27 0x12931d860 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int) 28 0x1294287f6 -[WebLayer drawInContext:] 29 0x7ff8103f199d CABackingStoreUpdate_ 30 0x7ff8104559fd invocation function for block in CA::Layer::display_() 31 0x7ff8103f09d1 -[CALayer _display]
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-31 18:35:26 PDT
<rdar://problem/99414110>
Karl Rackler
Comment 2 2022-08-31 18:38:17 PDT
I have marked this test as a flaky crash while this issue is investigated.
EWS
Comment 3 2022-08-31 18:43:46 PDT
Test gardening commit 254023@main (eace9d8846d3): <https://commits.webkit.org/254023@main> Reviewed commits have been landed. Closing PR #3899 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.