Bug 244641 - [WPE][GTK] Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0
Summary: [WPE][GTK] Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2022-08-31 16:51 PDT by Michael Catanzaro
Modified: 2022-09-28 10:28 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-08-31 16:51:22 PDT 
Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0

Since there are few users of the WPE 1.1 API, and we don't need to keep it around, WPE 2.0 will simply replace WPE 1.1. In contrast, the WPE 1.0 API is still required until Igalia is ready to phase out libsoup 2.
Comment 1 Michael Catanzaro 2022-08-31 16:53:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3886
Comment 2 EWS 2022-09-19 17:45:23 PDT 
Committed 254653@main (b2a6414f90b3): <https://commits.webkit.org/254653@main>

Reviewed commits have been landed. Closing PR #3886 and removing active labels.
Comment 3 Philippe Normand 2022-09-21 02:14:28 PDT 
This broke WPE builds where ENABLE_COG is ON BTW. Current cog depends on the 1.1 API.
Comment 4 Michael Catanzaro 2022-09-21 07:34:16 PDT 
I'm bamboozled... how does this option work? It doesn't seem to be used anywhere:

$ git grep 'ENABLE(COG)'
$ git grep ENABLE_COG
cmake/OptionsWPE.cmake:    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_COG PRIVATE ON)
cmake/WebKitFeatures.cmake:    WEBKIT_OPTION_DEFINE(ENABLE_COG "Toggle Cog browser compilation." PRIVATE OFF)
Comment 5 Michael Catanzaro 2022-09-28 10:28:41 PDT 
Problem was I was searching only under Source/, but ENABLE_COG is used under Tools/. Anyway it doesn't look hard to solve, just needs some attention from the cog developers to decide which branch to use based on the WPE API version.