RESOLVED FIXED Bug 244624
[GLib] Deprecate WebKitSettings enable-frame-flattening 
https://bugs.webkit.org/show_bug.cgi?id=244624
Summary [GLib] Deprecate WebKitSettings enable-frame-flattening
Michael Catanzaro
Reported 2022-08-31 12:22:51 PDT
Deprecate WebKitSettings enable-frame-flattening since the implementation was removed in bug #242883
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-08-31 13:53:39 PDT
We cannot remove the underlying preference from WebPreferences.yaml and WebPreferencesInternal.yaml because it still supports public API in WebKitLegacy/mac/WebView/WebPreferences.mm and WebKitLegacy/mac/WebView/WebView.mm.
Michael Catanzaro
Comment 2 2022-08-31 14:32:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3876
EWS
Comment 3 2022-08-31 16:02:26 PDT
Committed 254014@main (1978c2756325): <https://commits.webkit.org/254014@main> Reviewed commits have been landed. Closing PR #3876 and removing active labels.
Yanko Kaneti
Comment 4 2022-09-01 03:45:44 PDT
I am not sure I understand the logic here. It marks as deprecated which is OK, but also turns the setting in a noop default to false ? Which would not help evolution which explicitly sets it to true to actually use the now deprecated code Maybe my code comprehension is failing me..
Michael Catanzaro
Comment 5 2022-09-01 05:28:58 PDT
That's the patch for the main branch. For the 2.38 branch, I instead committed exactly the patch that you uploaded on Red Hat Bugzilla: https://github.com/WebKit/WebKit/commit/871eeae26321fc4d5f6769887f2aae42200b5a6e And a different deprecation that keeps the setting alive: https://github.com/WebKit/WebKit/commit/a94dc7e25c83a375fd9ac3e73f56c2794336b176
Yanko Kaneti
Comment 6 2022-09-01 05:31:11 PDT
Ah, thanks, I missed the branch difference. Sorry for the noise
Note You need to log in before you can comment on or make changes to this bug.