RESOLVED FIXED 244621
GCC does not have an error maximum, breaking EWS on bad patches 
https://bugs.webkit.org/show_bug.cgi?id=244621
Summary GCC does not have an error maximum, breaking EWS on bad patches
Elliott Williams
Reported 2022-08-31 11:38:51 PDT
For example: https://github.com/WebKit/WebKit/commit/fdc83ec3c441df44f9e272d1426baa01fdb287fe introduced errors in the WPE build, and caused https://ews-build.webkit.org/#/builders/8/builds/96909 to spend > 5 hrs compiling, generating millions of lines of output. 99% of those lines were error output, and there were 100k errors emitted in total. Clang avoids explosive situations like this by bailing out after 20 errors (configurable by the -ferror-limit=<n> option). GCC doesn't have an error limit by default, but one can be configured using -fmax-errors=<n>. We should use this to match GCC's behavior to clang's.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-08-31 15:59:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3870
EWS
Comment 2 2022-09-01 13:20:39 PDT
Committed 254063@main (c331d47aa73c): <https://commits.webkit.org/254063@main> Reviewed commits have been landed. Closing PR #3870 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-09-01 13:21:17 PDT
<rdar://problem/99453998>
Note You need to log in before you can comment on or make changes to this bug.