TextureMapper: Attach a depth buffer for BitmapTextureGL for 3D transform The current implementation is using only the depth buffer of the default framebuffer. To support nesting 3D rendering context (bug#241699), I'm going to attach a depth buffer for BitmapTextureGL.
Created attachment 461998 [details] Patch
Comment on attachment 461998 [details] Patch GTK EWS reported test failures. depth bits isn't enough. Using GL_DEPTH_COMPONENT24 passes the tests, But, this isn't available for ES2.0.
I found out another problem for WinCairo. It seems that ANGLE can't attach both a depth buffer and a stencil buffer to a fbo. WinCairo has to use a single depth/stencil buffer of GL_DEPTH24_STENCIL8_OES. Linux doesn't seem to have such problem.
<rdar://problem/99581351>
Created attachment 462718 [details] Patch
Comment on attachment 462718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462718&action=review r=me with nits > Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h:45 > +#if OS(WINDOWS) > +#define USE_TEXMAP_DEPTH_STENCIL_BUFFER 1 > +#else > +#define USE_TEXMAP_DEPTH_STENCIL_BUFFER 0 > +#endif From your commit message it seems like this might be better to be `#if USE(ANGLE)`? Also I feel like this should be in a WTF header not just hanging out here.
Comment on attachment 462718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462718&action=review Thank you very much for the review. >> Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h:45 >> +#endif > > From your commit message it seems like this might be better to be `#if USE(ANGLE)`? > > Also I feel like this should be in a WTF header not just hanging out here. GTK and WPE also enable USE_ANGLE. USE_ANGLE is nonsense anymore. We should remove it. I don't want to recompile whole WebKit just by changing TextureMapper configs. Not all USE_ macro definitions are in WTF. I think it's OK to be here.
Created attachment 462723 [details] [fast-cq] Patch for landing
Committed 255021@main (0793eb5a3182): <https://commits.webkit.org/255021@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462723 [details].