WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
244524
make_names.pl findTagName trie search code could be improved
https://bugs.webkit.org/show_bug.cgi?id=244524
Summary
make_names.pl findTagName trie search code could be improved
Cameron McCormack (:heycam)
Reported
2022-08-29 18:58:46 PDT
Two suggestions that came out of the
bug 244020
review: 1. When reaching the leaf of the trie, the suffix to compare against could be a string literal rather than an array of characters. 2. We sometimes put braces around single statements.
Attachments
Add attachment
proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1
2022-08-29 20:26:47 PDT
3. The generated code sometimes includes a sequence of single character if statement checks. These should be combined into a single memcmp.
Radar WebKit Bug Importer
Comment 2
2022-09-05 18:59:15 PDT
<
rdar://problem/99580507
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug