Bug 244459 - AX: Only cache and update AXPropertyName::IdentifierAttribute if !LOG_DISABLED
Summary: AX: Only cache and update AXPropertyName::IdentifierAttribute if !LOG_DISABLED
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-28 19:52 PDT by Tyler Wilcock
Modified: 2022-08-29 11:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.16 KB, patch)
2022-08-28 20:14 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (7.15 KB, patch)
2022-08-28 20:17 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-08-28 19:52:57 PDT 
We do expose AXDOMIdentifier, but it's only called by tests and not real AX clients, so we shouldn't spend the time caching and updating it unless logging is enabled (for debugging purposes).
Comment 1 Radar WebKit Bug Importer 2022-08-28 19:53:07 PDT 
<rdar://problem/99259089>
Comment 2 Tyler Wilcock 2022-08-28 20:14:27 PDT 
Created attachment 461960 [details]
Patch
Comment 3 Tyler Wilcock 2022-08-28 20:17:06 PDT 
Created attachment 461961 [details]
Patch
Comment 4 EWS 2022-08-29 11:35:59 PDT 
Committed 253917@main (95cb4d36cc5a): <https://commits.webkit.org/253917@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461961 [details].