Bug 244427 – REGRESSION (STP): Some properties fail to inherit via a query container on mutation

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

Hi,

While testing Safari TP, I found that some of our code completely broke (at least since TP152). I created a minimal test case here: https://codesandbox.io/s/serene-aj-gll158?file=/src/index.js:164-165

After clicking the button, the "Should show" test should be in red. On Chrome with container query enabled this works correctly, on Safari the content is completely hidden after the animation.

Thanks!

[Alexey Proskuryakov]

> After clicking the button, the "Should show" test should be in red.

I don't get any red in shipping Safari, Chrome or Firefox, and they all behave identically. Are you saying that they are all wrong?

I do get a different behavior in STP 152 - it shows red at first, but after clicking the button, part of the text indeed doesn't show up.

[Radar WebKit Bug Importer]

<rdar://problem/99237306>

(In reply to Alexey Proskuryakov from comment #1)
> > After clicking the button, the "Should show" test should be in red.
> 
> I don't get any red in shipping Safari, Chrome or Firefox, and they all
> behave identically. Are you saying that they are all wrong?
> 
> I do get a different behavior in STP 152 - it shows red at first, but after
> clicking the button, part of the text indeed doesn't show up.

Yes, this is exactly the issue. On Safari 152, when you click on the button the red text should appear, it does not.

Under Safari 152, everything being in a container media query is completely ignored by WAAPI, as if the styles were never invalidated.

[Antti Koivisto]

Created attachment 461975 [details]
reduction

Looks like there is some bug specific to 'visibility' where it fails to inherit correctly from a query container.

[Antti Koivisto]

Created attachment 462070 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Antti Koivisto]

Created attachment 462071 [details]
Patch

[Antti Koivisto]

Created attachment 462072 [details]
Patch

[EWS]

Committed 254042@main (9ba6488c8c4b): <https://commits.webkit.org/254042@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462072 [details].

[Antti Koivisto]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/40769