Bug 244417 – REGRESSION (252720@main): [ macOS wk1 Debug ] Three imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/ tests are a consistent crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Karl Rackler]

Description:
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002.html
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002.html

This test was consistently passing until at 252721@main when is started consistently crashing.

REPRODUCTION STEPS
I can reproduce this on 252721@main but cannot reproduce it on 252719@main or earlier.

Command: 
run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002.html

Result: 
Regressions: Unexpected crashes (1)
  imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002.html [ Crash ]

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-animations%2Fanimation-model%2Fanimation-types%2Faddition-per-property-002.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-animations%2Fanimation-model%2Fanimation-types%2Finterpolation-per-property-002.html&test=media%2Fmodern-media-controls%2Fmedia-documents%2Fclick-on-video-should-not-pause.html&platform=mac&style=debug&flavor=wk1

Crash Log:
No crash log found for DumpRenderTree:77363.

stdout:

stderr:
2022-08-26 15:54:02.199 DumpRenderTree[77363:18254320] Error: execSQLStatement:onConnection:toCompletionWithRetry:writeLockHelp - SQL=CREATE table cfurl_cache_response(entry_ID INTEGER PRIMARY KEY AUTOINCREMENT UNIQUE, 	 version INTEGER, hash_value INTEGER, storage_policy INTEGER, request_key TEXT UNIQUE, 	 time_stamp NOT NULL DEFAULT CURRENT_TIMESTAMP, partition TEXT);, error-code=1, error-message=table cfurl_cache_response already exists
2022-08-26 15:54:02.199 DumpRenderTree[77363:18254320] ERROR: NSURLStorageURLCacheDB _setDBSchema: DB=/Users/karlrackler/Library/Caches/DumpRenderTree/Cache.db response create - table cfurl_cache_response already exists. ErrCode: 1.
SHOULD NEVER BE REACHED
./css/StyleProperties.cpp(1335) : bool WebCore::MutableStyleProperties::setProperty(WebCore::CSSPropertyID, const WTF::String &, bool, WebCore::CSSParserContext)
1   0x1053c1439 WTFCrash
2   0x189c8b65b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x18ce67a6e WebCore::MutableStyleProperties::setProperty(WebCore::CSSPropertyID, WTF::String const&, bool, WebCore::CSSParserContext)
4   0x18c922a0b WebCore::processPropertyIndexedKeyframes(JSC::JSGlobalObject&, WebCore::Document&, JSC::Strong<JSC::JSObject, (JSC::ShouldStrongDestructorGrabLock)0>&&, WTF::Vector<WebCore::KeyframeEffect::ParsedKeyframe, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&)
5   0x18c91f75e WebCore::KeyframeEffect::processKeyframes(JSC::JSGlobalObject&, WebCore::Document&, JSC::Strong<JSC::JSObject, (JSC::ShouldStrongDestructorGrabLock)0>&&)
6   0x18c91eb8e WebCore::KeyframeEffect::create(JSC::JSGlobalObject&, WebCore::Document&, WebCore::Element*, JSC::Strong<JSC::JSObject, (JSC::ShouldStrongDestructorGrabLock)0>&&, std::__1::optional<std::__1::variant<double, WebCore::KeyframeEffectOptions> >&&)
7   0x18adfb844 WebCore::constructJSKeyframeEffect1(JSC::JSGlobalObject*, JSC::CallFrame*)
8   0x18adfab36 WebCore::JSDOMConstructor<WebCore::JSKeyframeEffect>::construct(JSC::JSGlobalObject*, JSC::CallFrame*)
9   0x485a1e4040c7
10  0x485a1e4bf15f
11  0x105a9334e llint_entry
12  0x105a933c9 llint_entry
13  0x105a944b8 llint_entry
14  0x105a933c9 llint_entry
15  0x105a933c9 llint_entry
16  0x105a6eeb0 vmEntryToJavaScript
17  0x106a14c12 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
18  0x106a142f9 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
19  0x106e3eb35 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
20  0x106e3ec7c JSC::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
21  0x18ca4f018 WebCore::JSExecState::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
22  0x18ca4ea8e WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&)
23  0x18ca4e849 WebCore::ScriptController::evaluateInWorldIgnoringException(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&)
24  0x18ca4f295 WebCore::ScriptController::evaluateIgnoringException(WebCore::ScriptSourceCode const&)
25  0x18d2d4b10 WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode const&)
26  0x18d2d2bb4 WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport)
27  0x18d7e8a8e WebCore::HTMLScriptRunner::runScript(WebCore::ScriptElement&, WTF::TextPosition const&)
28  0x18d7e8894 WebCore::HTMLScriptRunner::execute(WTF::Ref<WebCore::ScriptElement, WTF::RawPtrTraits<WebCore::ScriptElement> >&&, WTF::TextPosition const&)
29  0x18d7ced2a WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder()
30  0x18d7cf201 WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&)
31  0x18d7ce538 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode)

[Radar WebKit Bug Importer]

<rdar://problem/99207725>

[Karl Rackler]

Upon closer inspection, 252720@main modified StyleProperties.cpp and is when the test started consistently crashing.

[Karl Rackler]

I have marked this test as a consistent crash while this issue is investigated.

[EWS]

Test gardening commit 253847@main (1799d27c20bc): <https://commits.webkit.org/253847@main>

Reviewed commits have been landed. Closing PR #3725 and removing active labels.

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/4217

[EWS]

Committed 254998@main (3021ad87ed21): <https://commits.webkit.org/254998@main>

Reviewed commits have been landed. Closing PR #4217 and removing active labels.