RESOLVED FIXED 244374
Unify copies of SDKVariant.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=244374
Summary Unify copies of SDKVariant.xcconfig
David Kilzer (:ddkilzer)
Reported 2022-08-25 20:48:58 PDT
Unify copies of SDKVariant.xcconfig. Create a `Source/Configurations` folder and move one copy of `SDKVariant.xcconfig` into it, then remove the duplicate copies, then finally fix project references to use relative paths. The `Source/Configurations` folder is added to the WebKit.xcworkspace as well (since we can move other common files into this folder later). We place this in `Source` instead of in the top-level folder since it will make source submissions easier at Apple.
Attachments
Radar WebKit Bug Importer
Comment 1 2022-08-25 20:49:17 PDT
David Kilzer (:ddkilzer)
Comment 2 2022-08-25 20:57:30 PDT
EWS
Comment 3 2022-08-26 22:26:21 PDT
Committed 253857@main (024ecd89c769): <https://commits.webkit.org/253857@main> Reviewed commits have been landed. Closing PR #3688 and removing active labels.
David Kilzer (:ddkilzer)
Comment 4 2022-08-27 14:18:31 PDT
(In reply to David Kilzer (:ddkilzer) from comment #0) > Unify copies of SDKVariant.xcconfig. > > Create a `Source/Configurations` folder and move one copy of > `SDKVariant.xcconfig` into it, then remove the duplicate copies, then > finally fix project references to use relative paths. > > The `Source/Configurations` folder is added to the WebKit.xcworkspace as > well (since we can move other common files into this folder later). > > We place this in `Source` instead of in the top-level folder since it will > make source submissions easier at Apple. FYI, the `Configurations` folder was placed at the same level as the `Source` folder since there was a simple change to `Makefile` to make source submissions work.
Note You need to log in before you can comment on or make changes to this bug.