Bug 244339 - [IFC][Integration] Introduce InlineContentPainter
Summary: [IFC][Integration] Introduce InlineContentPainter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-25 10:20 PDT by zalan
Modified: 2022-08-25 18:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.58 KB, patch)
2022-08-25 10:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.60 KB, patch)
2022-08-25 15:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-25 10:20:02 PDT 
to paint IFC inline content
Comment 1 zalan 2022-08-25 10:21:37 PDT 
Created attachment 461860 [details]
Patch
Comment 2 Antti Koivisto 2022-08-25 12:57:34 PDT 
Comment on attachment 461860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461860&action=review

nice!

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765
> -class LayerPaintScope {

LineLayout::hitTest uses this. If this compiles it must be by accident.

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771
> +    if (!m_inlineContent)

Maybe we could eliminate these tests at some point, they shouldn't really happen
Comment 3 zalan 2022-08-25 15:16:42 PDT 
Created attachment 461869 [details]
Patch
Comment 4 EWS 2022-08-25 18:11:10 PDT 
Committed 253801@main (1ab9ad2f5f0d): <https://commits.webkit.org/253801@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461869 [details].
Comment 5 Radar WebKit Bug Importer 2022-08-25 18:12:16 PDT 
<rdar://problem/99164823>
Comment 6 zalan 2022-08-25 18:45:39 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 461860 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461860&action=review
> 
> nice!
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765
> > -class LayerPaintScope {
> 
> LineLayout::hitTest uses this. If this compiles it must be by accident.
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771
> > +    if (!m_inlineContent)
> 
> Maybe we could eliminate these tests at some point, they shouldn't really
> happen
yes, please!