Bug 24432 - Unify JSC/V8 DOMWindow.idl
Summary: Unify JSC/V8 DOMWindow.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Mike Belshe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-06 14:17 PST by Mike Belshe
Modified: 2009-03-09 12:48 PDT (History)
1 user (show)

See Also:

Attachments
patch (4.72 KB, patch)
2009-03-06 14:21 PST, Mike Belshe 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-06 14:17:28 PST 
There is no difference in functionality between JSC and V8.

Here are the changes:
* V8 implements shadowing in a different way from JSC; properties which cannot be shadowed add the V8DisallowShadowing attribute.
* JSC omits several properties from the IDL and adds them directly from JSDOMWindowBase.  V8 needs them here so they can be generated.

This change should have no effect on JSC, and both pass the layout tests.
Comment 1 Mike Belshe 2009-03-06 14:21:11 PST 
Created attachment 28372 [details]
patch
Comment 2 Eric Seidel (no email) 2009-03-06 18:49:23 PST 
Comment on attachment 28372 [details]
patch

Looks fine to me.  I'll again CC sam so he sees this go through his inbox.
Comment 3 Eric Seidel (no email) 2009-03-09 12:48:29 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/DOMWindow.idl
Committed r41533