RESOLVED FIXED24432
Unify JSC/V8 DOMWindow.idl 
https://bugs.webkit.org/show_bug.cgi?id=24432
Summary Unify JSC/V8 DOMWindow.idl
Mike Belshe
Reported 2009-03-06 14:17:28 PST
There is no difference in functionality between JSC and V8. Here are the changes: * V8 implements shadowing in a different way from JSC; properties which cannot be shadowed add the V8DisallowShadowing attribute. * JSC omits several properties from the IDL and adds them directly from JSDOMWindowBase. V8 needs them here so they can be generated. This change should have no effect on JSC, and both pass the layout tests.
Attachments
patch (4.72 KB, patch)
2009-03-06 14:21 PST, Mike Belshe 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-06 14:21:11 PST
Created attachment 28372 [details] patch
Eric Seidel (no email)
Comment 2 2009-03-06 18:49:23 PST
Comment on attachment 28372 [details] patch Looks fine to me. I'll again CC sam so he sees this go through his inbox.
Eric Seidel (no email)
Comment 3 2009-03-09 12:48:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/DOMWindow.idl Committed r41533
Note You need to log in before you can comment on or make changes to this bug.