RESOLVED FIXED 244292
test-webkitpy --all failures on main 
https://bugs.webkit.org/show_bug.cgi?id=244292
Summary test-webkitpy --all failures on main
Sam Sneddon [:gsnedders]
Reported 2022-08-24 03:14:32 PDT
There's quite a lot there :(
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2022-08-24 03:24:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3603
EWS
Comment 2 2022-08-28 09:45:12 PDT
Committed 253880@main (74b1edfb3f78): <https://commits.webkit.org/253880@main> Reviewed commits have been landed. Closing PR #3603 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-08-28 09:46:17 PDT
<rdar://problem/99250197>
Jonathan Bedard
Comment 4 2022-08-31 17:10:13 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/3889
EWS
Comment 5 2022-08-31 17:44:52 PDT
Committed 254020@main (a12e01f79c67): <https://commits.webkit.org/254020@main> Reviewed commits have been landed. Closing PR #3889 and removing active labels.
EWS
Comment 6 2022-09-07 13:40:47 PDT
Committed 252432.352@safari-7614-branch (8af621e21b22): <https://commits.webkit.org/252432.352@safari-7614-branch> Reviewed commits have been landed. Closing PR #45 and removing active labels.
EWS
Comment 7 2022-09-07 14:20:30 PDT
Committed 252432.353@safari-7614-branch (f7ec3ecb02a6): <https://commits.webkit.org/252432.353@safari-7614-branch> Reviewed commits have been landed. Closing PR #46 and removing active labels.
Fujii Hironori
Comment 8 2022-09-28 19:14:21 PDT
Adding '--all' switch is causing a problem for WinCairo buildbot (bug#245811). Why don't you just unskip some tests? https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/webkitpy/test/main.py#L77 Can I revert the '--all' switch part of the patch?
Fujii Hironori
Comment 9 2022-09-29 12:10:59 PDT
Reopen to revert.
Fujii Hironori
Comment 10 2022-10-04 15:03:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5000
EWS
Comment 11 2022-10-06 08:05:37 PDT
Committed 255219@main (7934e56e257a): <https://commits.webkit.org/255219@main> Reviewed commits have been landed. Closing PR #5000 and removing active labels.
Sam Sneddon [:gsnedders]
Comment 12 2022-11-24 05:02:57 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/6785
Sam Sneddon [:gsnedders]
Comment 13 2022-11-24 05:03:49 PST
*** Bug 248305 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 14 2022-11-24 12:08:36 PST
https://github.com/WebKit/WebKit/pull/5000#discussion_r988018816 > We can remove SVN tests, and probably git ones too, actually, since most of our git tooling lives in webkitscmpy now, which takes a different approach to testing than webkitpy > That being said, feels like the most immediate task is just the revert, we can clean up in future changes. Can we remove them?
Sam Sneddon [:gsnedders]
Comment 15 2022-11-24 14:54:59 PST
(In reply to Fujii Hironori from comment #14) > https://github.com/WebKit/WebKit/pull/5000#discussion_r988018816 > > > We can remove SVN tests, and probably git ones too, actually, since most of our git tooling lives in webkitscmpy now, which takes a different approach to testing than webkitpy > > That being said, feels like the most immediate task is just the revert, we can clean up in future changes. > > Can we remove them? I'd rather do these in separate PRs, in case we need to revert any of this again.
EWS
Comment 16 2022-12-06 14:59:23 PST
Committed 257437@main (73bf03b537e5): <https://commits.webkit.org/257437@main> Reviewed commits have been landed. Closing PR #6785 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.