Bug 244289 - WebGLRenderingContextBase::readPixels should allow null pixels on the IDL level
Summary: WebGLRenderingContextBase::readPixels should allow null pixels on the IDL level
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: webgl2conformance
  Show dependency treegraph
 
Reported: 2022-08-24 03:09 PDT by Kimmo Kinnunen
Modified: 2022-10-07 00:01 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-08-24 03:09:30 PDT
WebGLRenderingContextBase::readPixels should allow null pixels on the IDL level (including the .idl file) and emit INVALID_VALUE with an appropriate message instead of failing with JS TypeError.

Tested in https://github.com/KhronosGroup/WebGL/pull/3486
Comment 1 Radar WebKit Bug Importer 2022-08-24 04:12:38 PDT
<rdar://problem/99078383>
Comment 2 Kimmo Kinnunen 2022-08-24 04:15:09 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3605
Comment 3 EWS 2022-10-07 00:01:53 PDT
Committed 255256@main (e5af469c39da): <https://commits.webkit.org/255256@main>

Reviewed commits have been landed. Closing PR #3605 and removing active labels.