Bug 244259 - [ews] Duplicate Github status-bubbles for old hash on PRs
Summary: [ews] Duplicate Github status-bubbles for old hash on PRs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-23 11:57 PDT by Aakash Jain
Modified: 2022-08-23 12:46 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-08-23 11:57:02 PDT 
[ews] Duplicate Github status-bubbles for old hash on PRs. When a new commit is pushed to an old PR (older than when GitHub status-bubbles were launched), ews also creates status-bubbles for older pushes on that PRs. However, it doesn't store the comment id for those comments (for older commits). So, next time another commit is pushed to that PR, status-bubbles are duplicated for all the older commits.

e.g.: https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257 and https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257
Comment 1 Aakash Jain 2022-08-23 12:27:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3583
Comment 2 EWS 2022-08-23 12:45:27 PDT 
Committed 253692@main (f6b0e3a9159a): <https://commits.webkit.org/253692@main>

Reviewed commits have been landed. Closing PR #3583 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-23 12:46:17 PDT 
<rdar://problem/99046572>