WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
244259
[ews] Duplicate Github status-bubbles for old hash on PRs
https://bugs.webkit.org/show_bug.cgi?id=244259
Summary
[ews] Duplicate Github status-bubbles for old hash on PRs
Aakash Jain
Reported
2022-08-23 11:57:02 PDT
[ews] Duplicate Github status-bubbles for old hash on PRs. When a new commit is pushed to an old PR (older than when GitHub status-bubbles were launched), ews also creates status-bubbles for older pushes on that PRs. However, it doesn't store the comment id for those comments (for older commits). So, next time another commit is pushed to that PR, status-bubbles are duplicated for all the older commits. e.g.:
https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257
and
https://github.com/WebKit/WebKit/pull/2677#issuecomment-1224558257
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2022-08-23 12:27:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3583
EWS
Comment 2
2022-08-23 12:45:27 PDT
Committed
253692@main
(f6b0e3a9159a): <
https://commits.webkit.org/253692@main
> Reviewed commits have been landed. Closing PR #3583 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-08-23 12:46:17 PDT
<
rdar://problem/99046572
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug