WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
244205
Fix invalid %{public} %{private} format strings in cross-platform code
https://bugs.webkit.org/show_bug.cgi?id=244205
Summary
Fix invalid %{public} %{private} format strings in cross-platform code
Michael Catanzaro
Reported
2022-08-22 08:59:10 PDT
%{public} and %{private} are not valid format strings except on Apple platforms, and cannot be used in cross-platform code. Most uses can be replaced with the existing PUBLIC_LOG_STRING and PRIVATE_LOG_STRING. Since not everything we log is a string, I have added PUBLIC_LOG and PRIVATE_LOG as well to allow more generic use.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2022-08-22 09:01:33 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3537
EWS
Comment 2
2022-09-06 10:03:58 PDT
Committed
254189@main
(3454ee99a16d): <
https://commits.webkit.org/254189@main
> Reviewed commits have been landed. Closing PR #3537 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug