Bug 244173 – [LFC][IFC] text-overflow: ellipsis should not affect geometries

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

it's visual only operation.

[zalan]

Created attachment 461780 [details]
Patch

[Antti Koivisto]

Comment on attachment 461780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461780&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872
> +            if (!hasDamage(box))
> +                continue;

Maybe the hasDamage(box) test could go before all the type tests too and be done in one place only. Not sure about the inline-block case...

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 461780 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461780&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872
> > +            if (!hasDamage(box))
> > +                continue;
> 
> Maybe the hasDamage(box) test could go before all the type tests too and be
> done in one place only. Not sure about the inline-block case...
good point. will do in a followup patch.

[EWS]

Committed 253650@main (dfaf8254ed07): <https://commits.webkit.org/253650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461780 [details].

[Radar WebKit Bug Importer]

<rdar://problem/98988623>