Bug 24417 - [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings
Summary: [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-03-05 17:54 PST by Gustavo Noronha (kov)
Modified: 2009-03-06 05:24 PST (History)
0 users

See Also:

Attachments
proposed fix (1.97 KB, patch)
2009-03-05 17:54 PST, Gustavo Noronha (kov) 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-03-05 17:54:09 PST 
Those calls deal with the GTimer used to keep information about download elapsed time, but the timer may never get initialized if _start is not called. If nothing handles the download-requested signal, for example, this will emit nasty warning/critical messages in the terminal.
Comment 1 Gustavo Noronha (kov) 2009-03-05 17:54:38 PST 
Created attachment 28343 [details]
proposed fix
Comment 2 Mark Rowe (bdash) 2009-03-05 20:32:27 PST 
Comment on attachment 28343 [details]
proposed fix

r=me.  "existence" is misspelt in the ChangeLog, the comma is unnecessary there too, and perhaps the comments in the code could be a little more consistent (exists vs non-NULL).
Comment 3 Gustavo Noronha (kov) 2009-03-06 05:24:54 PST 
Landed as r41478.