Bug 244161 – REGRESSION (253522@main): [ macOS Debug ] Three imported/w3c/web-platform-tests/media-source/mediasource-changetype tests are a consistent crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Karl Rackler]

Description:
imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html
imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter.html
imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html

The first failure I saw on the dashboard was on  8/17/2022 at 253522@main with macOS Debug.

REPRODUCTION STEPS
I can reproduce this on 253523@main but cannot reproduce it on 253520@main or earlier.  I cannot isolate and repro down to the commit that introduced the change due to a lack of roots in the 253522@main-253521@main range.  

Command: 
run-webkit-tests --debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html

Result: 
Regressions: Unexpected crashes (1)
  imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Crash ]

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-changetype-play-negative.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-changetype-play-without-codecs-parameter.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-changetype-play.html&platform=mac&style=debug&limit=50000

Crash Log:
Thread 0 Crashed::   Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	       0x12c32b06e    WTFCrash
1   com.apple.WebKit              	       0x13a83175c    WebKit::GPUConnectionToWebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
2   com.apple.WebKit              	       0x13b1d8b5e    IPC::Connection::dispatchMessage(IPC::Decoder&)
3   com.apple.WebKit              	       0x13b1d9224    IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
4   com.apple.WebKit              	       0x13b1d97cc    IPC::Connection::dispatchOneIncomingMessage()
5   com.apple.WebKit              	       0x13b1f9314    IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_16::operator()()

[Radar WebKit Bug Importer]

<rdar://problem/98928273>

[Karl Rackler]

Created attachment 461768 [details]
Crash Log

[Karl Rackler]

Revert "[Media] Destroy media player on fatal playback error"

This reverts because causing three imported/w3c/web-platform-tests/media-source/mediasource-changetype tests are a consistent crash.

Committed 253621@main (a44a944): https://commits.webkit.org/253621@main

[Karl Rackler]

Verified Revert "[Media] Destroy media player on fatal playback error" at 253621@main; tests are no longer crashing.