Bug 24409 - re-work layer destruction to clear m_renderer and m_layer after destruction
Summary: re-work layer destruction to clear m_renderer and m_layer after destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 15:37 PST by Eric Seidel (no email)
Modified: 2009-03-06 11:39 PST (History)
0 users

See Also:


Attachments
Changes to RenderLayer destruction to hopefully help catch an ellusive crasher (8.95 KB, patch)
2009-03-05 15:37 PST, Eric Seidel (no email)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-03-05 15:37:34 PST
re-work layer destruction to clear m_renderer and m_layer after destruction

This work was initially inspired by:
http://code.google.com/p/chromium/issues/detail?id=7829

I don't know that this will actually help us track down that crash, but I do think that it is cleanup worth doing.
Comment 1 Eric Seidel (no email) 2009-03-05 15:37:49 PST
Created attachment 28332 [details]
Changes to RenderLayer destruction to hopefully help catch an ellusive crasher

 WebCore/ChangeLog                          |   26 ++++++++++++++++++++++++++
 WebCore/rendering/RenderBox.cpp            |    2 +-
 WebCore/rendering/RenderBoxModelObject.cpp |   20 +++++++++++++++-----
 WebCore/rendering/RenderBoxModelObject.h   |    5 ++++-
 WebCore/rendering/RenderLayer.cpp          |   17 ++++++++---------
 WebCore/rendering/RenderLayer.h            |    6 ++++--
 WebCore/rendering/RenderObject.cpp         |    5 ++---
 WebCore/rendering/RenderWidget.cpp         |   17 ++++++++---------
 8 files changed, 68 insertions(+), 30 deletions(-)
Comment 2 Dave Hyatt 2009-03-05 18:26:20 PST
Comment on attachment 28332 [details]
Changes to RenderLayer destruction to hopefully help catch an ellusive crasher

r=me. Make sure to test thoroughly, though, since you have changed the timing of stuff (especially in RenderWidget).
Comment 3 Eric Seidel (no email) 2009-03-05 18:33:25 PST
(In reply to comment #2)
> (From update of attachment 28332 [details] [review])
> r=me. Make sure to test thoroughly, though, since you have changed the timing
> of stuff (especially in RenderWidget).

I've run all of the layout tests, full pass.
Comment 4 Eric Seidel (no email) 2009-03-06 11:39:33 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBox.cpp
	M	WebCore/rendering/RenderBoxModelObject.cpp
	M	WebCore/rendering/RenderBoxModelObject.h
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderLayer.h
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderWidget.cpp
Committed r41469