Bug 244038 - Make css/css-scroll-snap/scroll-target-margin-005.html pass
Summary: Make css/css-scroll-snap/scroll-target-margin-005.html pass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-17 09:15 PDT by Tim Nguyen (:ntim)
Modified: 2022-09-06 12:44 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-08-17 09:15:46 PDT 
There are 3 issues:
- The focus() ScrollRectToVisibleOptions does not match the scrollIntoView() one
- The test uses <input type="date">, which redirects focus inside the UA shadow root, so we don't take in account the shadow host scroll margin
- The test should wait for a tick, since scrolling to the focused element doesn't happen immediately in WebKit
Comment 1 Tim Nguyen (:ntim) 2022-08-17 10:01:12 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3412
Comment 2 Radar WebKit Bug Importer 2022-08-24 09:16:13 PDT 
<rdar://problem/99087807>
Comment 3 Nikos Mouchtaris 2022-08-25 14:02:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3673
Comment 4 EWS 2022-09-06 12:44:11 PDT 
Committed 254195@main (a728674047d7): <https://commits.webkit.org/254195@main>

Reviewed commits have been landed. Closing PR #3673 and removing active labels.