Bug 244033 - [LFC][IFC] Add support for out-of-flow content
Summary: [LFC][IFC] Add support for out-of-flow content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-17 08:26 PDT by zalan
Modified: 2022-09-05 11:14 PDT (History)
12 users (show)

See Also:

Attachments
Patch (16.84 KB, patch)
2022-08-17 08:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (17.08 KB, patch)
2022-08-17 10:07 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (18.72 KB, patch)
2022-08-17 16:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.56 KB, patch)
2022-08-17 16:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (22.45 KB, patch)
2022-08-20 07:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (22.61 KB, patch)
2022-08-20 11:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (22.62 KB, patch)
2022-08-20 22:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-17 08:26:02 PDT 
ssia
Comment 1 zalan 2022-08-17 08:35:04 PDT 
Created attachment 461692 [details]
Patch
Comment 2 zalan 2022-08-17 10:07:52 PDT 
Created attachment 461693 [details]
Patch
Comment 3 Antti Koivisto 2022-08-17 10:28:39 PDT 
Comment on attachment 461693 [details]
Patch

very nice
Comment 4 Antti Koivisto 2022-08-17 10:31:37 PDT 
Comment on attachment 461693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461693&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:268
> +static inline std::tuple<const InlineDisplay::Box*, const InlineDisplay::Box*> previousAndNextDisplayBox(const Box& outOfFlowBox, const DisplayBoxes& displayBoxes)

'inline' is probably unnecessary

This sound rather generic, maybe it could be something like previousAndNextDisplayBoxForStaticPosition?
Comment 5 zalan 2022-08-17 16:45:04 PDT 
Created attachment 461700 [details]
Patch
Comment 6 zalan 2022-08-17 16:51:21 PDT 
Created attachment 461701 [details]
Patch
Comment 7 zalan 2022-08-20 07:45:14 PDT 
Created attachment 461761 [details]
Patch
Comment 8 zalan 2022-08-20 11:02:19 PDT 
Created attachment 461767 [details]
Patch
Comment 9 Tim Nguyen (:ntim) 2022-08-20 11:39:11 PDT 
Comment on attachment 461767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461767&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:374
> +    auto isSpportedFloatingOrPositioned = [&] (auto& renderer) {

typo: isSupportedFloatingOrPositioned
Comment 10 zalan 2022-08-20 22:32:38 PDT 
Created attachment 461776 [details]
Patch
Comment 11 EWS 2022-08-21 07:27:28 PDT 
Committed 253628@main (669ac300289c): <https://commits.webkit.org/253628@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461776 [details].
Comment 12 Radar WebKit Bug Importer 2022-08-21 07:28:16 PDT 
<rdar://problem/98945681>