Bug 244010 - `git-webkit pfr` fails when using angle brackets for bugs.webkit.org URL
Summary: `git-webkit pfr` fails when using angle brackets for bugs.webkit.org URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2022-08-16 14:50 PDT by David Kilzer (:ddkilzer)
Modified: 2022-08-31 08:49 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-08-16 14:50:05 PDT
`git-webkit ptr` fails when using angle brackets for bugs.webkit.org URL.

In Bug 244008, I originally formatted the git commit message like this:

'''
    Leak of id<MTLArgumentEncoder> in rx::(anonymous)::InitArgumentBufferEncoder()
    <https://bugs.webkit.org/show_bug.cgi?id=244008>
    <rdar://98747531>

'''

However, that resulted in the following error:

```
$ ./Tools/Scripts/git-webkit pfr
Branch 'main' set up to track remote branch 'main' from 'origin'.
From https://github.com/WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch ddkilzer/bug-244008-fix-leak-of-id_MTLArgumentEncoder is up to date.
    Found 1 commit...
Total errors found: 0 in 1 files
Your issue is redacted, diverting to a secure, non-origin remote you have access to.
Making PR against 'apple' instead of 'origin'
Enumerating objects: 19, done.
Counting objects: 100% (19/19), done.
Delta compression using up to 24 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.01 KiB | 129.00 KiB/s, done.
Total 10 (delta 9), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (9/9), completed with 9 local objects.
remote: 
remote: Create a pull request for 'ddkilzer/bug-244008-fix-leak-of-id_MTLArgumentEncoder' on GitHub by visiting:
remote:      https://github.com/ddkilzer/WebKit-apple/pull/new/ddkilzer/bug-244008-fix-leak-of-id_MTLArgumentEncoder
remote: 
To https://github.com/ddkilzer/WebKit-apple.git
 * [new branch]                ddkilzer/bug-244008-fix-leak-of-id_MTLArgumentEncoder -> ddkilzer/bug-244008-fix-leak-of-id_MTLArgumentEncoder
Everything up-to-date
Traceback (most recent call last):
  File "./Tools/Scripts/git-webkit", line 69, in <module>
    sys.exit(program.main(
  File "WebKit.github/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 148, in main
    return parsed.main(
  File "WebKit.github/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 507, in main
    return cls.create_pull_request(repository, args, branch_point)
  File "WebKit.github/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 434, in create_pull_request
    pr = remote_repo.pull_requests.create(
  File "WebKit.github/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 148, in create
    sys.stderr.write(self.tracker.parse_error(response.json()))
AttributeError: 'PRGenerator' object has no attribute 'tracker'
$ 
```

I had to remove the angle brackets from the bugs.webkit.org URL to workaround the issue.
Comment 1 David Kilzer (:ddkilzer) 2022-08-16 14:53:42 PDT
This happened while `main` was at commit 84f547237bc57d93b4f5b79eff64589e5ab3aa5c (253486@main).
Comment 2 Radar WebKit Bug Importer 2022-08-18 16:46:34 PDT
<rdar://problem/98856552>
Comment 3 Jonathan Bedard 2022-08-23 10:36:42 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3580
Comment 4 EWS 2022-08-23 16:42:09 PDT
Committed 253710@main (b6e3977a551d): <https://commits.webkit.org/253710@main>

Reviewed commits have been landed. Closing PR #3580 and removing active labels.
Comment 5 EWS 2022-08-31 08:49:08 PDT
Committed 252432.299@safari-7614-branch (248bf5256d56): <https://commits.webkit.org/252432.299@safari-7614-branch>

Reviewed commits have been landed. Closing PR #39 and removing active labels.