WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
244006
Change kdebug check for signposts
https://bugs.webkit.org/show_bug.cgi?id=244006
Summary
Change kdebug check for signposts
Ben Nham
Reported
2022-08-16 13:29:29 PDT
In
bug 243699
we conditionalized emitting signposts on the result of kdebug_is_enabled for WebKit's DBG_ARIADNE category. However, this ends up enabled in more cases than we'd want, especially on internal builds. This is because the DBG_ARIADNE is enabled by default by tailspin on internal builds. This means signposts are enabled more often than we want, which leads log bloat in the persistent log. To fix this, we should conditionalize emitting signposts based on a category not included in the default internal tailspin filter instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-08-16 13:30:04 PDT
<
rdar://problem/98745594
>
Ben Nham
Comment 2
2022-08-16 13:34:28 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3373
EWS
Comment 3
2022-08-17 12:32:00 PDT
Committed
253533@main
(74562f9b5ce6): <
https://commits.webkit.org/253533@main
> Reviewed commits have been landed. Closing PR #3373 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug