WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24400
Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount" media element attributes
https://bugs.webkit.org/show_bug.cgi?id=24400
Summary
Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"...
Eric Carlson
Reported
2009-03-05 13:09:42 PST
The "start" and "end" attributes have been removed from the HTML5 spec. The "loopStart", "loopEnd", "currentLoop", and "playCount" attributes have been replaced by "loop".
Attachments
proposed patch
(722.02 KB, patch)
2009-03-05 13:13 PST
,
Eric Carlson
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2009-03-05 13:13:03 PST
Created
attachment 28322
[details]
proposed patch
Simon Fraser (smfr)
Comment 2
2009-03-05 13:41:01 PST
Comment on
attachment 28322
[details]
proposed patch
> 2009-03-04 Simon Fraser <
simon.fraser@apple.com
> > > Rubber-stamped by Eric Seidel.
Lots of removed changelogs here.
> Index: LayoutTests/media/video-loop-expected.txt > =================================================================== > +EXPECTED (media.currentTime == '8.399999618530273') OK
Seems like this might be sensitive to platform floating point rounding issues. Is there a more reliable way to test it?
> Index: LayoutTests/media/video-seek-past-end-paused-expected.txt > =================================================================== > --- LayoutTests/media/video-seek-past-end-paused-expected.txt (revision 41447) > +++ LayoutTests/media/video-seek-past-end-paused-expected.txt (working copy) > @@ -1,9 +1,18 @@ > Test that seeking paused video past it's duration time sets currentTime to duration and leaves video paused. > > +RUN(video.src = 'content/test.mp4') > RUN(video.load()) > + > EVENT(load) > -RUN(video.currentTime = 500) > -EVENT(timeupdate) > -EXPECTED (video.currentTime == '8.399999618530273') OK > +EXPECTED (video.paused == 'true') OK > +EXPECTED (video.ended == 'false') OK > +RUN(video.play()) > + > +EXPECTED (video.paused == 'false') OK > +EXPECTED (media.currentTime > '0') OK > + > +EXPECTED (video.ended == 'true') OK > +EXPECTED (media.currentTime == '8.399999618530273') OK
Ditto. r=me if you address those issues.
David Levin
Comment 3
2009-04-08 16:26:18 PDT
Previous committed <
http://trac.webkit.org/changeset/41461
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug