Bug 243957 - Use iterative algorithm for resetStyleForNonRenderedDescendants
Summary: Use iterative algorithm for resetStyleForNonRenderedDescendants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Miguel Salinas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-15 14:55 PDT by Miguel Salinas
Modified: 2022-08-26 13:22 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Salinas 2022-08-15 14:55:23 PDT 
WebCore::Style::resetStyleForNonRenderedDescendants is currently recursive and can stack overflow on very deep DOM trees. We should rewrite this to be iterative to avoid crashing.
Comment 1 Radar WebKit Bug Importer 2022-08-16 15:42:48 PDT 
<rdar://problem/98752283>
Comment 2 Miguel Salinas 2022-08-16 15:58:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3384
Comment 3 Miguel Salinas 2022-08-16 16:08:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3385
Comment 4 EWS 2022-08-26 13:22:11 PDT 
Committed 253837@main (9a78fa7ef78b): <https://commits.webkit.org/253837@main>

Reviewed commits have been landed. Closing PR #3385 and removing active labels.