Bug 243947 - [git-webkit] `git revert` does not produce a meaningful commit message
Summary: [git-webkit] `git revert` does not produce a meaningful commit message
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082 241202
  Show dependency tree / graph
 
Reported: 2022-08-15 11:58 PDT by Elliott Williams
Modified: 2023-11-08 08:55 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-08-15 11:58:48 PDT 
When you run `git revert <commit>`, the commit message generated is a blank WebKit-style commit message, and not the standard revert message from git.

I believe this is caused by https://bugs.webkit.org/show_bug.cgi?id=241202, which updated the prepare-commit-msg hook to generate better revert messages for git-webkit. `git webkit revert <identifier>` works, but I don't think we should break the normal revert workflow.
Comment 1 Radar WebKit Bug Importer 2022-08-22 11:59:41 PDT 
<rdar://problem/98992367>
Comment 2 Brianna Fan 2023-10-16 15:11:09 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19135
Comment 3 Brianna Fan 2023-11-07 13:39:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20127
Comment 4 EWS 2023-11-07 22:00:14 PST 
Committed 270375@main (a4e364130e7c): <https://commits.webkit.org/270375@main>

Reviewed commits have been landed. Closing PR #20127 and removing active labels.
Comment 5 Jonathan Bedard 2023-11-08 08:55:59 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/20171