Bug 243911 - ReadableStream should fail at read-loop if non Uint8Array is enqueued
Summary: ReadableStream should fail at read-loop if non Uint8Array is enqueued
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-12 17:57 PDT by Yusuke Suzuki
Modified: 2022-08-29 12:14 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-08-12 17:57:58 PDT 
https://streams.spec.whatwg.org/#read-loop

> If chunk is not a Uint8Array object, reject promise with a TypeError and abort these steps.

This is tested in WPT wasm/webapi/wasm_stream_compile_test.html, and currently failing because we are not rejecting non Uint8Array buffer.
https://wpt.fyi/results/wasm/webapi/wasm_stream_compile_test.html?label=experimental&label=master&aligned
Comment 1 Radar WebKit Bug Importer 2022-08-12 17:58:51 PDT 
<rdar://problem/98595437>
Comment 2 youenn fablet 2022-08-26 00:37:32 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3695
Comment 3 EWS 2022-08-29 12:14:44 PDT 
Committed 253918@main (afdd4c9f10bd): <https://commits.webkit.org/253918@main>

Reviewed commits have been landed. Closing PR #3695 and removing active labels.