Bug 24389 - WebKitGTK+ crashes when cancelling plugin loads
Summary: WebKitGTK+ crashes when cancelling plugin loads
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gustavo Noronha (kov)
Keywords: Gtk, Soup
Depends on:
Reported: 2009-03-05 09:50 PST by Gustavo Noronha (kov)
Modified: 2009-03-05 10:51 PST (History)
0 users

See Also:

backtrace (25.97 KB, text/plain)
2009-03-05 09:52 PST, Gustavo Noronha (kov)
no flags Details
proposed fix (2.20 KB, patch)
2009-03-05 09:53 PST, Gustavo Noronha (kov)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-03-05 09:50:11 PST
If you go to a page that uses plugins such as flash, and click a link or cancel the load, the browser will crash. Investigating the problem I found out that our ResourceHandle implementation calls didFinishLoading in it's cancel method, which is completely bogus, the way I understand the workflow, and is not done by any other ports except for the Windows (WebCore/platform/network/win/ResourceHandleWin.cpp) port.

I made a patch removing the calls to didFinishLoading, and tested with acid2, acid3, and the webkit layout tests, and found no regression. The crash is also gone.
Comment 1 Gustavo Noronha (kov) 2009-03-05 09:52:32 PST
Created attachment 28307 [details]
Comment 2 Gustavo Noronha (kov) 2009-03-05 09:53:08 PST
Created attachment 28308 [details]
proposed fix
Comment 3 Alexey Proskuryakov 2009-03-05 10:28:14 PST
Comment on attachment 28308 [details]
proposed fix

> +        didFinishLoading here is mostly innofensive for most loads, but

Typo: inoffensive. Please add a bug URL to ChangeLog.

Comment 4 Gustavo Noronha (kov) 2009-03-05 10:51:45 PST
Landed as r41453.