Bug 24382 - request to add SH4 platform
Summary: request to add SH4 platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 07:32 PST by Simone
Modified: 2009-03-05 23:18 PST (History)
1 user (show)

See Also:


Attachments
Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal (1.90 KB, patch)
2009-03-05 07:37 PST, Simone
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simone 2009-03-05 07:32:13 PST
I had some problems related to non-aligned memory accesses as done in 
WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) 
function for the SH4 platform.
My question is: can you add support in WebKit sources for SH4 platform?

In attachment you can find a patch (against WebKit trunk) that 
introduce the SH4 platform and solves the non-aligned memory accesses (I use 
the same code as per ARM platform).
Comment 1 Simone 2009-03-05 07:37:19 PST
Created attachment 28299 [details]
Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal

1. Introduce the SH4 platform
2. Solves the non-aligned memory accesses for SH4 (I use 
the same code as per ARM platform).
Comment 2 David Kilzer (:ddkilzer) 2009-03-05 21:03:01 PST
Comment on attachment 28299 [details]
Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal

r=me

NOTE: Need to add the bug title and bug number to the ChangeLogs before landing.
Comment 3 David Kilzer (:ddkilzer) 2009-03-05 23:18:17 PST
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Platform.h
	M	WebCore/ChangeLog
	M	WebCore/platform/text/AtomicString.cpp
Committed r41475

http://trac.webkit.org/changeset/41475