REOPENED243812
Handle transform changes causing overflow updates 
https://bugs.webkit.org/show_bug.cgi?id=243812
Summary Handle transform changes causing overflow updates
Tim Nguyen (:ntim)
Reported 2022-08-10 20:39:26 PDT
// FIXME: transform changes really need to trigger layout. See RenderElement::adjustStyleDifference(). css/css-transforms/change-scale-wide-range.html is one affected WPT.
Attachments
Patch (4.00 KB, patch)
2022-09-10 14:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.45 KB, patch)
2022-10-07 19:55 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.81 KB, patch)
2022-10-07 22:00 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (9.74 KB, patch)
2022-10-10 17:06 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-10 20:39:54 PDT
<rdar://problem/98486403>
Tim Nguyen (:ntim)
Comment 2 2022-08-11 14:20:01 PDT Comment hidden (obsolete)
alan
Comment 3 2022-09-10 14:58:12 PDT
Created attachment 462258 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2022-09-10 20:21:17 PDT
Comment on attachment 462258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462258&action=review > Source/WebCore/rendering/RenderElement.cpp:258 > + diff = std::max(diff, StyleDifference::SimplifiedLayout); I wonder if we can clean up code around this FIXME: https://searchfox.org/wubkat/rev/7111cbd9fd80f1b153ea0d0a1805420bae87211c/Source/WebCore/rendering/RenderLayerCompositor.cpp#1775
alan
Comment 5 2022-09-11 09:31:28 PDT
fast/repaint/multiple-backgrounds-style-change.html ^^ background image repaint optimization fails. We should certainly be able to identify this no-repaint case when there's no change in overflow.
alan
Comment 6 2022-10-07 19:55:55 PDT
Created attachment 462873 [details] Patch
alan
Comment 7 2022-10-07 22:00:54 PDT
Created attachment 462876 [details] Patch
alan
Comment 8 2022-10-10 17:06:01 PDT
Created attachment 462918 [details] [fast-cq]Patch
EWS
Comment 9 2022-10-11 14:40:36 PDT
Committed 255406@main (fc014916474a): <https://commits.webkit.org/255406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462918 [details].
WebKit Commit Bot
Comment 10 2022-12-08 10:32:36 PST
Re-opened since this is blocked by bug 248959
Radar WebKit Bug Importer
Comment 11 2022-12-08 17:47:27 PST
<rdar://problem/103160679>
Note You need to log in before you can comment on or make changes to this bug.