WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
243808
Changes to the filter property are sometimes ignored
https://bugs.webkit.org/show_bug.cgi?id=243808
Summary
Changes to the filter property are sometimes ignored
Cameron McCormack (:heycam)
Reported
2022-08-10 18:42:04 PDT
Before
bug 242497
, we would rebuild the SVGResources for a client SVG element whenever we call into its RenderObject's layout function. This was wasteful if we know that they layout change doesn't affect the resource, so in
bug 242497
(and in the bugs I'm working under
bug 242420
), I am making the various RenderSVGResource handle caching data based on the layout information of the client. When a RenderSVGResource is removed (e.g. because its render tree is being re-created, or the element is removed), we remove it from all clients' SVGResources and mark the clients as needing layout. Now that we no longer unconditionally rebuild the SVGResources for the client under its layout function, we need another way to indicate that it needs to be rebuilt.
Attachments
Add attachment
proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1
2022-08-10 18:42:37 PDT
rdar://97335496
Cameron McCormack (:heycam)
Comment 2
2022-08-10 18:46:46 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/3209
Sammy Gill
Comment 3
2022-11-03 12:52:33 PDT
***
Bug 183871
has been marked as a duplicate of this bug. ***
Cameron McCormack (:heycam)
Comment 4
2022-11-03 17:06:16 PDT
rdar://97335496
Cameron McCormack (:heycam)
Comment 5
2022-11-03 17:06:29 PDT
***
Bug 247411
has been marked as a duplicate of this bug. ***
EWS
Comment 6
2022-11-04 13:26:24 PDT
Committed
256335@main
(64eee924e808): <
https://commits.webkit.org/256335@main
> Reviewed commits have been landed. Closing PR #3209 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug