Bug 243781 – [GStreamer] REGRESSION(253289@main): Broke debug builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/Ref.h:119:52: error: invalid argument type 'WebCore::VideoFrameGStreamer' to unary expression
    bool operator!() const { ASSERT(m_ptr); return !*m_ptr; }
                                                   ^~~~~~~
/app/webkit/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:195:5: note: in instantiation of member function 'WTF::Ref<WebCore::VideoFrameGStreamer>::operator!' requested here
    ASSERT(newVideoFrame);
    ^

[Adrian Perez]

I suppose the assertion should be moved into PLATFORM(COCOA). Another option
would be to explicitly declare the variable as RefPtr<VideFrameGStreamer> instead of using “auto” to avoid the compiler deducing it can use Ref<T>.
I am not sure what option is preferred in this case.

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/3190

[Philippe Normand]

Pull request: https://github.com/WebKit/WebKit/pull/3192

[EWS]

Committed 253296@main (ec1e02abd6f9): <https://commits.webkit.org/253296@main>

Reviewed commits have been landed. Closing PR #3192 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/98451754>