RESOLVED FIXED 24377
[GTK] Comply better with coding style guidelines in ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=24377
Summary [GTK] Comply better with coding style guidelines in ResourceHandleSoup
Xan Lopez
Reported 2009-03-05 03:34:20 PST
ditto.
Attachments
resourcehandlesoupstyle.patch (14.09 KB, patch)
2009-03-05 03:37 PST, Xan Lopez
mrowe: review+
Xan Lopez
Comment 1 2009-03-05 03:37:21 PST
Created attachment 28298 [details] resourcehandlesoupstyle.patch
Mark Rowe (bdash)
Comment 2 2009-03-05 04:13:45 PST
Comment on attachment 28298 [details] resourcehandlesoupstyle.patch r=me. I mentioned a few other points on IRC that would be good to address: m_input_stream and m_bufsize don't match our style guidelines, and there are variables in readCallback and openCallback that are declared several lines before they're first used.
Xan Lopez
Comment 3 2009-03-05 04:49:18 PST
Committed in r41447 with the fixes mentioned and approved on IRC. Thanks!
Note You need to log in before you can comment on or make changes to this bug.