Bug 243766 - [Painting] Add support for decorating box based text box painting
Summary: [Painting] Add support for decorating box based text box painting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 239069 (view as bug list)
Depends on: 243526 243564 243575 243576 243577 243610 243611 243619 243621 243632 243647 243712 243732 243752 243756 243762 243765 243792 243921 243922 245209 245316
Blocks: 243928
  Show dependency tree / graph
 
Reported: 2022-08-09 21:58 PDT by zalan
Modified: 2022-09-17 14:01 PDT (History)
14 users (show)

See Also:

Attachments
Patch (9.53 KB, patch)
2022-08-09 22:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.61 KB, patch)
2022-08-11 22:03 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (23.83 KB, patch)
2022-08-12 13:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (23.83 KB, patch)
2022-08-12 14:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (23.83 KB, patch)
2022-08-13 06:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.92 KB, patch)
2022-08-13 08:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.93 KB, patch)
2022-08-13 09:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-09 21:58:39 PDT 
ssia
Comment 1 zalan 2022-08-09 22:01:14 PDT 
Created attachment 461518 [details]
Patch
Comment 2 zalan 2022-08-11 22:03:37 PDT 
Created attachment 461554 [details]
Patch
Comment 3 zalan 2022-08-12 07:50:38 PDT 
Comment on attachment 461554 [details]
Patch

2 small issues still:
1, subpixel width difference on nested inline box underline
2, marked text style is ignored on propagated (nested) inline box drawing
Comment 4 zalan 2022-08-12 08:08:24 PDT 
oh and vertical writing mode, that's still quite a mess.
Comment 5 zalan 2022-08-12 13:21:33 PDT 
Created attachment 461566 [details]
Patch
Comment 6 EWS Watchlist 2022-08-12 13:23:18 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 7 zalan 2022-08-12 14:56:51 PDT 
Created attachment 461567 [details]
Patch
Comment 8 zalan 2022-08-13 06:56:18 PDT 
Created attachment 461575 [details]
Patch
Comment 9 zalan 2022-08-13 08:12:15 PDT 
Created attachment 461578 [details]
Patch
Comment 10 zalan 2022-08-13 09:59:17 PDT 
Created attachment 461583 [details]
Patch
Comment 11 EWS 2022-08-13 22:40:20 PDT 
Committed 253406@main (519c36a6ca3c): <https://commits.webkit.org/253406@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461583 [details].
Comment 12 Radar WebKit Bug Importer 2022-08-13 22:41:16 PDT 
<rdar://problem/98629973>
Comment 14 Tim Nguyen (:ntim) 2022-08-14 22:38:48 PDT 
*** Bug 239069 has been marked as a duplicate of this bug. ***
Comment 15 zalan 2022-08-15 08:14:45 PDT 
(In reply to zalan from comment #13)
> <rdar://problem/
> 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274
> 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9
> 8537188&98640439&98645175>
and rdar://problem/98468166
Comment 16 zalan 2022-09-15 16:31:19 PDT 
This regressed bug 245209
Comment 17 zalan 2022-09-16 07:28:09 PDT 
(In reply to zalan from comment #15)
> (In reply to zalan from comment #13)
> > <rdar://problem/
> > 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274
> > 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9
> > 8537188&98640439&98645175>
> and rdar://problem/98468166
and rdar://problem/99950939
Comment 18 zalan 2022-09-17 14:01:39 PDT 
(In reply to zalan from comment #17)
> (In reply to zalan from comment #15)
> > (In reply to zalan from comment #13)
> > > <rdar://problem/
> > > 98121284&98188799&98188799&98194323&98209140&98223304&98240132&98250164&98274
> > > 655&98254665&98273126&98319548&98450106&98450839&98458659&98470568&98505292&9
> > > 8537188&98640439&98645175>
> > and rdar://problem/98468166
> and rdar://problem/99950939
and rdar://problem/100071411