Bug 24376 - Spilt up InspectorController.cpp into separate classes
Summary: Spilt up InspectorController.cpp into separate classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 24355
  Show dependency tree / graph
 
Reported: 2009-03-04 21:52 PST by Dimitri Glazkov (Google)
Modified: 2009-03-05 09:15 PST (History)
2 users (show)

See Also:

Attachments
Split up InspectorController, v1 (53.12 KB, patch)
2009-03-04 21:54 PST, Dimitri Glazkov (Google) 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-03-04 21:52:29 PST 
This will become necessary once we introduce the IDL and JS bindings.
Comment 1 Dimitri Glazkov (Google) 2009-03-04 21:54:32 PST 
Created attachment 28297 [details]
Split up InspectorController, v1

 WebCore/ChangeLog                                 |   23 ++
 WebCore/GNUmakefile.am                            |    8 +
 WebCore/WebCore.pro                               |    4 +
 WebCore/WebCore.scons                             |    4 +
 WebCore/WebCore.vcproj/WebCore.vcproj             |   32 ++
 WebCore/WebCore.xcodeproj/project.pbxproj         |   32 ++
 WebCore/WebCoreSources.bkl                        |    4 +
 WebCore/inspector/ConsoleMessage.cpp              |  117 +++++++
 WebCore/inspector/ConsoleMessage.h                |   70 +++++
 WebCore/inspector/InspectorController.cpp         |  341 +--------------------
 WebCore/inspector/InspectorDOMStorageResource.cpp |   69 +++++
 WebCore/inspector/InspectorDOMStorageResource.h   |   72 +++++
 WebCore/inspector/InspectorDatabaseResource.cpp   |   67 ++++
 WebCore/inspector/InspectorDatabaseResource.h     |   71 +++++
 WebCore/inspector/InspectorResource.cpp           |  178 +++++++++++
 WebCore/inspector/InspectorResource.h             |  110 +++++++
 16 files changed, 865 insertions(+), 337 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-03-04 21:55:07 PST 
I didn't do any prettying up. This is a straight split-up.
Comment 3 Mark Rowe (bdash) 2009-03-05 04:18:19 PST 
Is there a reason you're using a different license header in the new files than what exists in InspectorController.cpp?  I'm pretty sure you'll need to keep the existing license header.
Comment 4 Dimitri Glazkov (Google) 2009-03-05 09:03:14 PST 
Oh, good point. I will update the headers before landing.
Comment 5 Dimitri Glazkov (Google) 2009-03-05 09:15:11 PST 
Landed as http://trac.webkit.org/changeset/41449.